Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Screen Sharing audio #36

Closed
saintplay opened this issue Aug 28, 2021 · 2 comments · Fixed by #37
Closed

Support for Screen Sharing audio #36

saintplay opened this issue Aug 28, 2021 · 2 comments · Fixed by #37

Comments

@saintplay
Copy link

Hello! Congrats for this awesome project, I've been trying several open source solutions for WebRTC, but LiveKit really stands out for its simplicity and flexibility. Documentation, is great too.

It would be great to support audio when requesting a screen sharing stream.

I don't know if this is better suitable as an option or as default.

window.navigator.mediaDecies({ audio: true, video: true })

Because to receive an audio track the user needs the explicitly check the "share audio" anyway.

Regards

@davidzhao
Copy link
Member

hi @saintplay, we should add support for audio as some browsers do support it. Unfortunately, this will change the API slightly since the current API would return only a LocalVideoTrack.

@saintplay
Copy link
Author

saintplay commented Aug 28, 2021

What about createLocalScreenTracks?

In plural, similar to createLocalTracks for getUserMedia.

Where all tracks are created with the name "screen" (This identifier is key for some applications")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants