Read capapbilites from RtcRTPReceiver instead of from sender (#1088)

* Read capapbilites from RtcRTPReceiver instead of from sender * Create lovely-cups-tell.md * Add comments
livekit · Mar 23, 2024 · 0953a61 · 0953a61
1 parent f75c9fb
commit 0953a61
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/lovely-cups-tell.md b/.changeset/lovely-cups-tell.md
@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+Read capapbilites from RtcRTPReceiver instead of from sender
diff --git a/src/room/RTCEngine.ts b/src/room/RTCEngine.ts
@@ -653,12 +653,13 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
     kind: Track.Kind,
     videoCodec: VideoCodec,
   ) {
-    if (!('getCapabilities' in RTCRtpSender)) {
+    if (!('getCapabilities' in RTCRtpReceiver)) {
       return;
     }
-    const cap = RTCRtpSender.getCapabilities(kind);
+    // when setting codec preferences, the capabilites need to be read from the RTCRtpReceiver
+    const cap = RTCRtpReceiver.getCapabilities(kind);
     if (!cap) return;
-    this.log.debug('get sender capabilities', { ...this.logContext, cap });
+    this.log.debug('get receiver capabilities', { ...this.logContext, cap });
     const matched: RTCRtpCodecCapability[] = [];
     const partialMatched: RTCRtpCodecCapability[] = [];
     const unmatched: RTCRtpCodecCapability[] = [];