Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elevenlabs voice settings breaking #586

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Aug 6, 2024

11labs API requires style float and use_speaker_boost boolean. defaulting to None gets translated to JSON as null type. this sets them to their default values noted in the API here: https://api.elevenlabs.io/v1/voices/settings/default

Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: f3aceab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-elevenlabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbsp nbsp force-pushed the nbsp/fix/11-voicesettings branch from d6a9a6d to 69b780b Compare August 6, 2024 06:10
@nbsp
Copy link
Member Author

nbsp commented Aug 6, 2024

just noticed that this does break our API, as the default for speaker boosting is now True and it used to be False; do we keep it as it was?

@theomonnom
Copy link
Member

theomonnom commented Aug 6, 2024

Are the defaults safe when listing the voices using this fnc?
async def list_voices(self) -> List[Voice]:

@nbsp
Copy link
Member Author

nbsp commented Aug 6, 2024

Are the defaults safe when listing the voices using this fnc?
async def list_voices(self) -> List[Voice]:

that function sets settings=None, which changes the behaviour of the stock voices now, yes

@theomonnom
Copy link
Member

theomonnom commented Aug 6, 2024

Looking at their docs, they seem to explicitly set it on the examples? https://github.com/elevenlabs/elevenlabs-python/blob/a75c7e7e0b2aa8d04225ca34e2e387ccd0ba13ac/README.md#%EF%B8%8F-voices

On their 11labs python-client, I see that they also default these stuff to None

@nbsp nbsp force-pushed the nbsp/fix/11-voicesettings branch from 69b780b to 0336682 Compare August 6, 2024 23:05
@nbsp
Copy link
Member Author

nbsp commented Aug 6, 2024

new method just strips the Nones from the object before passing it to the JSON encoder, and doesn't mess with our defaults, so everything should be the same.

Looking at their docs, they seem to explicitly set it on the examples? elevenlabs/elevenlabs-python@a75c7e7/README.md#%EF%B8%8F-voices

On their 11labs python-client, I see that they also default these stuff to None

i don't think elevenlabs' Python client even supports professional or cloned voices, they errored as well.

@nbsp nbsp merged commit 7934b45 into main Aug 6, 2024
4 checks passed
@nbsp nbsp deleted the nbsp/fix/11-voicesettings branch August 6, 2024 23:08
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
ittailup added a commit to ittailup/livekit-agents that referenced this pull request Aug 12, 2024
SuJingnan pushed a commit to SuJingnan/agents that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants