-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix elevenlabs voice settings breaking #586
Conversation
🦋 Changeset detectedLatest commit: f3aceab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d6a9a6d
to
69b780b
Compare
just noticed that this does break our API, as the default for speaker boosting is now |
Are the defaults safe when listing the voices using this fnc? |
that function sets |
Looking at their docs, they seem to explicitly set it on the examples? https://github.com/elevenlabs/elevenlabs-python/blob/a75c7e7e0b2aa8d04225ca34e2e387ccd0ba13ac/README.md#%EF%B8%8F-voices On their 11labs python-client, I see that they also default these stuff to None |
livekit-plugins/livekit-plugins-elevenlabs/livekit/plugins/elevenlabs/tts.py
Outdated
Show resolved
Hide resolved
69b780b
to
0336682
Compare
new method just strips the
i don't think elevenlabs' Python client even supports professional or cloned voices, they errored as well. |
This reverts commit 7934b45.
11labs API requires
style
float anduse_speaker_boost
boolean. defaulting to None gets translated to JSON asnull
type. this sets them to their default values noted in the API here: https://api.elevenlabs.io/v1/voices/settings/default