Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a few docstrings and corrected typos #542

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Added a few docstrings and corrected typos #542

merged 4 commits into from
Aug 3, 2024

Conversation

davidzhao
Copy link
Member

No description provided.

@davidzhao davidzhao requested review from theomonnom and a team July 29, 2024 05:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c91aff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nbsp
nbsp previously requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one potential change, otherwise lgtm

livekit-agents/livekit/agents/worker.py Outdated Show resolved Hide resolved
@davidzhao davidzhao merged commit 2423841 into main Aug 3, 2024
4 checks passed
@davidzhao davidzhao deleted the some-doc-strings branch August 3, 2024 21:41
@willsmanley willsmanley mentioned this pull request Aug 11, 2024
Closed
SuJingnan pushed a commit to SuJingnan/agents that referenced this pull request Nov 26, 2024
@davidzhao @theomonnom
Added a few docstrings and corrected typos (livekit#542)
c0d8c73 
Co-authored-by: Théo Monnom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

@nbsp nbsp nbsp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidzhao @theomonnom @nbsp