use changesets/changesets for versioning #409
Conversation
|
Not familiar with this CI, can it generate a CHANGELOG file for every package we have? |
|
can you add livekit-plugins-rag and livekit-plugins-minimal before merging? 🙏 |
not merging until Lukas gets another look at this |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "name": "livekit-plugins/livekit-plugins-cartesia", | |||
There was a problem hiding this comment.
If this is the name that will be shown to users, mb this is better?
| "name": "livekit-plugins/livekit-plugins-cartesia", | |
| "name": "livekit-plugins-cartesia", |
There was a problem hiding this comment.
this is because we don't know which packages are and which aren't under livekit-plugins unless we do this. it's easier to strip it in the CI than to figure out whether we need to add it
There was a problem hiding this comment.
it's used programmatically to know where to cd in the CI
There was a problem hiding this comment.
maybe we can add a comment either in the publish-package.yml (or in the README) about what naming format we expect/need for this logic to work. Just as a reference once we add more lateron.
There was a problem hiding this comment.
maybe in the README for livekit-plugins-minimal, since that might be copied over as boilerplate for new packages?
There was a problem hiding this comment.
sounds good, the root README sounds also appropriate as the naming convention is not necessarily restricted to plugins
There was a problem hiding this comment.
having trouble fitting this anywhere in the root README, it feels too end-user focused and this is internal dev doc
i think the plugin part is good, i don't assume we'll add anything to anywhere but the plugin directory in this repository
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "name": "livekit-plugins/livekit-plugins-cartesia", | |||
There was a problem hiding this comment.
maybe we can add a comment either in the publish-package.yml (or in the README) about what naming format we expect/need for this logic to work. Just as a reference once we add more lateron.
|
Is it possible to push dev versions with it? |
No description provided.