Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry text that failed to send to elevenlabs + fix skipped task_done() call #152

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Retry text that failed to send to elevenlabs + fix skipped task_done() call #152

merged 1 commit into from
Feb 7, 2024

Conversation

keepingitneil
Copy link
Contributor

@keepingitneil keepingitneil commented Feb 5, 2024 •
edited
Loading

Elevenlabs closes websockets when you don't send text fast enough. We would currently drop that text and short circuit out of the task_done() call.

@keepingitneil keepingitneil marked this pull request as ready for review February 5, 2024 23:40
@keepingitneil keepingitneil mentioned this pull request Feb 5, 2024
Closed
@keepingitneil keepingitneil changed the title Fixes to Elevenlabs Retry text that failed to send to elevenlabs + fix skipped task_done() call Feb 5, 2024
davidzhao
davidzhao approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@keepingitneil keepingitneil merged commit ddc168e into main Feb 7, 2024
2 checks passed
@keepingitneil keepingitneil deleted the neil/11 branch February 7, 2024 00:10
askable-nic added a commit to askableorg/aimod-poc-livekit-agent that referenced this pull request Feb 8, 2024
@askable-nic
Squashed commit of the following:
a9da4d9 
commit 5fab872
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 17:18:48 2024 -0800

    Kitt to handle empty deepgram text + elevenlabs bug fix (livekit#155)

    hotfix

commit 7661824
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 16:25:35 2024 -0800

    Bump deepgram version (livekit#154)

commit ddc168e
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 16:10:52 2024 -0800

    Fixes to Elevenlabs (livekit#152)

commit 5555526
Author: David Zhao <[email protected]>
Date:   Tue Feb 6 09:12:38 2024 -0800

    Update KITT and other plugins to use end_of_speech field (livekit#153)

    * Update KITT and other plugins to use end_of_speech field

    Tested with KITT. It significantly improves the end of speech behavior so that
    we are giving it a 1s wait before starting to process user input.

    * ruff on 3.10

    * use ruff action

    * fixed ruff

commit a98a7c1
Author: Paul Lockett <[email protected]>
Date:   Tue Feb 6 00:02:51 2024 -0800

    update tts init to export StreamAdapter (livekit#149)

commit 604d7e3
Author: Sean Muirhead <[email protected]>
Date:   Mon Feb 5 21:35:55 2024 -0800

    Update deepgram endpointing  (livekit#145)

    * deepgram: Add min_silence_duration to deepgram client.

    deepgram controls vad by endpointing parameter, this fix allows to configure min_silence_duration in agents layer

    * add utterance_end_ms and speech_final to Deepgram plugin

    * add utterance_end_ms and speech_final to Deepgram plugin

    * expose speech_final as end_of_speech

    ---------

    Co-authored-by: Lam Nguyen <[email protected]>
askable-nic added a commit to askableorg/aimod-poc-livekit-agent that referenced this pull request Feb 22, 2024
@askable-nic
Squashed commit of the following:
17209f3 
commit 5fab872
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 17:18:48 2024 -0800

    Kitt to handle empty deepgram text + elevenlabs bug fix (livekit#155)

    hotfix

commit 7661824
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 16:25:35 2024 -0800

    Bump deepgram version (livekit#154)

commit ddc168e
Author: Neil Dwyer <[email protected]>
Date:   Tue Feb 6 16:10:52 2024 -0800

    Fixes to Elevenlabs (livekit#152)

commit 5555526
Author: David Zhao <[email protected]>
Date:   Tue Feb 6 09:12:38 2024 -0800

    Update KITT and other plugins to use end_of_speech field (livekit#153)

    * Update KITT and other plugins to use end_of_speech field

    Tested with KITT. It significantly improves the end of speech behavior so that
    we are giving it a 1s wait before starting to process user input.

    * ruff on 3.10

    * use ruff action

    * fixed ruff

commit a98a7c1
Author: Paul Lockett <[email protected]>
Date:   Tue Feb 6 00:02:51 2024 -0800

    update tts init to export StreamAdapter (livekit#149)

commit 604d7e3
Author: Sean Muirhead <[email protected]>
Date:   Mon Feb 5 21:35:55 2024 -0800

    Update deepgram endpointing  (livekit#145)

    * deepgram: Add min_silence_duration to deepgram client.

    deepgram controls vad by endpointing parameter, this fix allows to configure min_silence_duration in agents layer

    * add utterance_end_ms and speech_final to Deepgram plugin

    * add utterance_end_ms and speech_final to Deepgram plugin

    * expose speech_final as end_of_speech

    ---------

    Co-authored-by: Lam Nguyen <[email protected]>
SuJingnan pushed a commit to SuJingnan/agents that referenced this pull request Nov 26, 2024
@keepingitneil
Fixes to Elevenlabs (livekit#152)
de9f73f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@theomonnom theomonnom Awaiting requested review from theomonnom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepingitneil @davidzhao