Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated has_field? with field? to support Protobuf 4.0 #19

Merged
merged 1 commit into from
Sep 6, 2015
Merged

Replace deprecated has_field? with field? to support Protobuf 4.0 #19

merged 1 commit into from
Sep 6, 2015

Conversation

film42
Copy link
Contributor

@film42 film42 commented Jul 27, 2015

#18

Note: This doesn't resolve the attributes_from_proto usage which doesn't have an explicit end of life.

DEPRECATION WARNING: UserMessage#email_domain field usage is deprecated. (called from attributes_from_proto at protobuf-activerecord/lib/protobuf/active_record/transformation.rb:174)

@film42
Copy link
Contributor Author

film42 commented Aug 28, 2015

Show me some love? https://www.youtube.com/watch?v=Ps2Jc28tQrw

liveh2o added a commit that referenced this pull request Sep 6, 2015
Replace deprecated has_field? with field? to support Protobuf 4.0
@liveh2o liveh2o merged commit 480611f into liveh2o:master Sep 6, 2015
@liveh2o
Copy link
Owner

liveh2o commented Sep 6, 2015

Released in v3.2.1

@film42 film42 deleted the gt/protobuf_deprecations branch September 6, 2015 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants