Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for aws_credentials #21

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Jul 7, 2022

Files:

config/credentials

[default]
aws_access_key_id = <aws_access_key_id>
aws_secret_access_key = <aws_secret_access_key>

config/config

[default]
region = us-east-1

config/credentials_with_token (with aws sts get-session-token)

[default]
aws_access_key_id = <session_aws_access_key_id>
aws_secret_access_key = <session_aws_secret_access_key>
aws_session_token = <aws_session_token>

@aleDsz aleDsz self-assigned this Jul 7, 2022
lib/req_athena.ex Outdated Show resolved Hide resolved
lib/req_athena.ex Outdated Show resolved Hide resolved
lib/req_athena.ex Outdated Show resolved Hide resolved
@aleDsz aleDsz force-pushed the feature/support-aws_credentials branch from e266ac2 to e3435b0 Compare July 8, 2022 17:26
lib/req_athena.ex Outdated Show resolved Hide resolved
lib/req_athena.ex Outdated Show resolved Hide resolved
lib/req_athena.ex Outdated Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass, ship it!

@aleDsz aleDsz merged commit eaa2878 into main Jul 11, 2022
@aleDsz aleDsz deleted the feature/support-aws_credentials branch July 11, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants