Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layers for Chart Cell #9

Merged
9 commits merged into from
Jun 2, 2022
Merged

Layers for Chart Cell #9

9 commits merged into from
Jun 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2022

CleanShot 2022-06-01 at 20 57 08@2x
CleanShot 2022-06-01 at 20 57 24@2x

@ghost ghost requested review from jonatanklosko and josevalim June 2, 2022 02:54
@josevalim
Copy link
Contributor

It looks gorgeous! I just sent minor nitpicks to the CSS. There is just one last nitpick here:

image

Can you see the buttons on the right are not vertically aligned? Can you please take a look at it?

@ghost ghost requested review from josevalim and jonatanklosko June 2, 2022 17:01
jonatanklosko
jonatanklosko approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@ghost ghost merged commit 8affc83 into livebook-dev:main Jun 2, 2022
@ghost ghost deleted the cg-chart-cell-layers branch June 2, 2022 17:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim Awaiting requested review from josevalim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josevalim @jonatanklosko