-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggleable fields #22
Conversation
Functionality wise, it looks great to me, I only have concerns about the layout since we have too many boxes now. I think we should probably use a different design inside the box. Today we have this:
and I would go with something like this:
I will try to submit a mockup soon. |
Here is a mockup: But I would consider removing the select border altogether: Here is the CSS I used but I was doing those changes in the browser, perhaps some of those deserve to be new classes altogether: .field-settings-container {
padding: 4px 10px;
border-radius: 0.5rem;
margin-bottom: 4px;
border: 1px solid var(--gray-200);
}
.field-settings-container .field {
margin-bottom: 4px;
}
.field-settings-container .field:last-child {
margin-bottom: 0;
}
.field-settings-container .input-label {
margin-bottom: 0;
}
.field-settings-container select {
border: 0;
padding-right: 16px;
background-color: transparent;
background-position: center right;
}
.field-settings-container select:focus {
border: 0;
} |
33eee12
to
cd7a576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
@josevalim your call about the UI. I think the boxy feeling is mostly because we have the smart cell border close to the options border, but I don't have cleaner alternative in mind right now.
This PR is a preparation for us to support advanced fields with nested options and introduces the following changes:
CleanShot.2022-10-23.at.01.02.43.mp4