Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nif_panicked error for categorical data - explorer/issues/787 #123

Merged

Conversation

lkarthee
Copy link
Contributor

elixir-explorer/explorer#787

Added compute_frequencies?/1 to check whether we can compute frequencies for categorical data.

check whether we can compute frequencies for categorical data
Copy link
Contributor

@cristineguadelupe cristineguadelupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkarthee Thanks for your help, just two small adjustments!

lib/kino/explorer.ex Outdated Show resolved Hide resolved
lib/kino/explorer.ex Outdated Show resolved Hide resolved
backward compatibility for explorer = 0.7.2
@lkarthee
Copy link
Contributor Author

lkarthee commented Jan 1, 2024

@cristineguadelupe made changes as per discussion.

@cristineguadelupe cristineguadelupe merged commit c0592b7 into livebook-dev:main Jan 1, 2024
1 check passed
@lkarthee lkarthee deleted the list_string_frequencies_fix branch January 2, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants