Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for not in contains operations #115

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mfeckie
Copy link
Contributor

@mfeckie mfeckie commented Nov 20, 2023

I was doing some stuff with explorer today and noticed there's no option for not contains.

It looks like a straightforward change, so I had a go at adding it.

I'm not 100% sure it makes sense for the binary and category types, but it seems to match their usages.

Happy to make changes if I've made some incorrect assumptions

Have tested it on a local livebook and seems to work

Copy link
Contributor

@cristineguadelupe cristineguadelupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfeckie!

@cristineguadelupe cristineguadelupe merged commit fd8b3e8 into livebook-dev:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants