Fix: invalid var names (#103)

livebook-dev · Sep 4, 2023 · 0b9e4d4 · 0b9e4d4
1 parent 64db015
commit 0b9e4d4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/lib/kino_explorer/data_transform_cell.ex b/lib/kino_explorer/data_transform_cell.ex
@@ -434,6 +434,7 @@ defmodule KinoExplorer.DataTransformCell do
   defp to_quoted(%{"data_frame" => df, "assign_to" => variable} = attrs) do
     attrs = Map.new(attrs, fn {k, v} -> convert_field(k, v) end)
     missing_require = attrs.missing_require
+    variable = if variable && Kino.SmartCell.valid_variable_name?(variable), do: variable
 
     nodes =
       attrs.operations

diff --git a/test/kino_explorer/data_transform_cell_test.exs b/test/kino_explorer/data_transform_cell_test.exs
@@ -1036,6 +1036,37 @@ defmodule KinoExplorer.DataTransformCellTest do
              """
     end
 
+    test "source with export to an invalid var" do
+      root = %{"data_frame_alias" => DF, "assign_to" => "exported_df invalid"}
+
+      operations = %{
+        filters: [
+          %{
+            "column" => "name",
+            "filter" => "equal",
+            "type" => "string",
+            "value" => "Ana",
+            "active" => true,
+            "operation_type" => "filters"
+          },
+          %{
+            "column" => "id",
+            "filter" => "less",
+            "type" => "integer",
+            "value" => "2",
+            "active" => true,
+            "operation_type" => "filters"
+          }
+        ]
+      }
+
+      attrs = build_attrs(root, operations)
+
+      assert DataTransformCell.to_source(attrs) == """
+             people |> DF.to_lazy() |> DF.filter(name == "Ana" and id < 2) |> DF.collect()\
+             """
+    end
+
     test "source with inactive operations" do
       root = %{"data_frame_alias" => DF, "assign_to" => "exported_df"}