-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Google BigQuery #7
Conversation
8f50814
to
26bd5b2
Compare
26bd5b2
to
2eeb12d
Compare
88bba71
to
0b36c10
Compare
What happens if we get an error from google? e.g. there's a syntax error in the query which would probably result in a HTTP 400. I believe in that case ReqBigQuery would return a Two things:
|
f000183
to
f156057
Compare
I'll implement how to show the Google BigQuery help box with Service Account credentials JSON generation, so this PR isn't ready to merge yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐱 !!
f156057
to
5ba1094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
@aleDsz I believe we need to do one more change. If the user didn't select a credentials file, we should start Goth without the :source option so it can do the application default credential thing and if that fails, there is a good error message. Only if the user dropped credentials file, we'd explicitly set :source. WDYT? |
I agree, we should remove |
KinoDB.-.BigQuery.mp4