Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update req_athena support #27

Merged
merged 13 commits into from
Jul 14, 2022
Merged

Update req_athena support #27

merged 13 commits into from
Jul 14, 2022

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Jul 13, 2022 •
edited
Loading

TODO LIST

  • Add support for workgroup and token new options
  • Improve validation with workgroup and/or output_location options, as conditional fields
  • Improve required fields validations
  • Add support for cache_query option for each SQL cell
  • Update req_athena dependency to 0.1.1 (see more here)
  • Add help text for users that they can authenticate through SmartCell fields or aws cli

Screenshots

Connection Cell

Without aws_credentials:

image

With aws_credentials:

image

SQL Cell

image
image

@aleDsz aleDsz self-assigned this Jul 13, 2022
@aleDsz aleDsz marked this pull request as draft July 13, 2022 21:43
@aleDsz aleDsz requested a review from jonatanklosko July 13, 2022 21:47
jonatanklosko
jonatanklosko reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just a couple comments :)

jonatanklosko
jonatanklosko approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@aleDsz aleDsz marked this pull request as ready for review July 14, 2022 15:07
@aleDsz aleDsz force-pushed the feature/support-req_athena-aws_credentials branch from 3b74fdc to 7c9303f Compare July 14, 2022 15:14
@aleDsz aleDsz force-pushed the feature/support-req_athena-aws_credentials branch from 7c9303f to 877145c Compare July 14, 2022 15:19
@aleDsz aleDsz merged commit 2a03d0d into livebook-dev:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees

@aleDsz aleDsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleDsz @jonatanklosko