Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with new Goth version #18

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Update with new Goth version #18

merged 2 commits into from
Jun 29, 2022

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Jun 29, 2022

  • Add support for optional :source option
  • Add support to upload refresh token
  • Update goth and req_bigquery dependencies

@aleDsz aleDsz self-assigned this Jun 29, 2022
@aleDsz aleDsz merged commit b53629c into livebook-dev:main Jun 29, 2022
jonatanklosko
jonatanklosko reviewed Jun 29, 2022
View reviewed changes
lib/kino_db/connection_cell.ex
Comment on lines +158 to +159
cond do
match?(%{"type" => "service_account"}, attrs["credentials"]) ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a case like

Suggested change
cond do
match?(%{"type" => "service_account"}, attrs["credentials"]) ->
case attrs["credentials"] do
%{"type" => "service_account"} ->

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll improve that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko left review comments

@josevalim josevalim josevalim approved these changes

Assignees

@aleDsz aleDsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleDsz @josevalim @jonatanklosko