Add stream option to text generation task #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 22, 2023
josevalim
reviewed
Aug 22, 2023
|
They may want to do either in an actual application, so this way we have an example of both. I don't have a strong preference though, your call! |
|
I would go with the simpler UI and simpler code. They can remove the option if they feel adventurous. :) |
jonatanklosko
commented
Aug 22, 2023
| @@ -126,8 +126,52 @@ export async function init(ctx, payload) { | |||
| `, | |||
| }; | |||
|
|
|||
| const BaseSwitch = { | |||
There was a problem hiding this comment.
I'm gonna keep this, since we will use it in the future. In particular for #18.
josevalim
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kino_bbb_stream.mov