fix early deletion of wasm state schema (envoyproxy#227)

Signed-off-by: Kuat Yessenov <[email protected]>
liuxu623 · Jun 22, 2020 · afc9467 · afc9467
1 parent 71de2b0
commit afc9467
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/source/extensions/common/wasm/context.cc b/source/extensions/common/wasm/context.cc
@@ -1087,8 +1087,12 @@ WasmResult Context::setProperty(absl::string_view path, absl::string_view value)
 
 WasmResult Context::declareProperty(absl::string_view path,
                                     std::unique_ptr<const WasmStatePrototype> state_prototype) {
-  state_prototypes_[path] = std::move(state_prototype);
-  return WasmResult::Ok;
+  // Do not delete existing schema since it can be referenced by state objects.
+  if (state_prototypes_.find(path) == state_prototypes_.end()) {
+    state_prototypes_[path] = std::move(state_prototype);
+    return WasmResult::Ok;
+  }
+  return WasmResult::BadArgument;
 }
 
 void Context::scriptLog(spdlog::level::level_enum level, absl::string_view message) {