Bugfix(precheck): only check TCP socket while check port in use.

liuminjian · Apr 18, 2023 · e6ed0b6 · e6ed0b6
1 parent d59ff96
commit e6ed0b6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/internal/task/step/shell.go b/internal/task/step/shell.go
@@ -142,6 +142,7 @@ type (
 		Filter    string
 		Listening bool // display listening sockets
 		NoHeader  bool // Suppress header line
+		TCP       bool // display only TCP sockets
 		Success   *bool
 		Out       *string
 		module.ExecOptions
@@ -414,6 +415,9 @@ func (s *SocketStatistics) Execute(ctx *context.Context) error {
 	if s.NoHeader {
 		cmd.AddOption("--no-header")
 	}
+	if s.TCP {
+		cmd.AddOption("--tcp")
+	}
 
 	out, err := cmd.Execute(s.ExecOptions)
 	return PostHandle(s.Success, s.Out, out, err, errno.ERR_GET_CONNECTION_INFORMATION_FAILED)

diff --git a/internal/task/task/checker/network.go b/internal/task/task/checker/network.go
@@ -89,6 +89,7 @@ func NewCheckPortInUseTask(curveadm *cli.CurveAdm, dc *topology.DeployConfig) (*
 			Filter:      fmt.Sprintf(FORMAT_FILTER_SPORT, address.Port),
 			Listening:   true,
 			NoHeader:    true,
+			TCP:         true,
 			Success:     &success,
 			Out:         &out,
 			ExecOptions: curveadm.ExecOptions(),