[apache#5976] Improvement(bin):Add validation checks to the startup s…

…cripts to prevent incorrect usage
liuchunhao · Dec 24, 2024 · a5dec5f · a5dec5f
1 parent a58b7f8
commit a5dec5f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/bin/common.sh → bin/common.sh.template b/bin/common.sh → bin/common.sh.template
@@ -18,6 +18,13 @@
 # Referred from Apache Submarine's common.sh implementation
 # bin/common.sh
 
+GRAVITINO_VERSION=GRAVITINO_VERSION_PLACEHOLDER
+if [[ "$GRAVITINO_VERSION" == *_VERSION_PLACEHOLDER ]]; then
+  echo "GRAVITINO_VERSION is not set. Please make sure you are running the script from the distribution/package/bin and before running the script, run './gradle clean build -x test compileDistribution'"
+  exit 1
+fi
+
+
 if [ -L "${BASH_SOURCE-$0}" ]; then
   FWDIR=$(dirname "$(readlink "${BASH_SOURCE-$0}")")
 else

diff --git a/bin/gravitino-iceberg-rest-server.sh → ...gravitino-iceberg-rest-server.sh.template b/bin/gravitino-iceberg-rest-server.sh → ...gravitino-iceberg-rest-server.sh.template
diff --git a/bin/gravitino.sh → bin/gravitino.sh.template b/bin/gravitino.sh → bin/gravitino.sh.template
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -598,7 +598,7 @@ tasks {
           fileName.replace(".template", "")
         }
         eachFile {
-          if (name == "gravitino-env.sh") {
+          if (name == "gravitino-env.sh" || name == "common.sh") {
             filter { line ->
               line.replace("GRAVITINO_VERSION_PLACEHOLDER", "$version")
             }
@@ -643,7 +643,7 @@ tasks {
           fileName.replace(".template", "")
         }
         eachFile {
-          if (name == "gravitino-env.sh") {
+          if (name == "gravitino-env.sh" || name == "common.sh") {
             filter { line ->
               line.replace("GRAVITINO_VERSION_PLACEHOLDER", "$version")
             }