Change timestep in time-averaging-interval test to flag rounding errors #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@liuchihl found that this test was erroneously passing because the timestep that was chosen just happened to not be very prone to the rounding errors that cause this bug: CliMA#3670 I have changed the timestep to the nearby value of 0.01, which should be more useful in testing against bugs related floating point rounding errors in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liuchihl found that this test was erroneously passing because the timestep that was chosen just happened to not be very prone to the rounding errors that cause this bug: CliMA#3670
I have changed the timestep to the nearby value of 0.01, which should be more useful in testing against bugs related floating point rounding errors in the future!