Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running --interactive mode still modifies my libs.versions.toml file #146

Open
Zordid opened this issue Mar 5, 2024 · 3 comments
Open
Milestone

Comments

@Zordid
Copy link

Zordid commented Mar 5, 2024

Describe the issue
As per documentation, running in interactive mode should not modify the libs.versions.toml file - but it does.
It changes how my plugins are declared, from { id = "...", version = "..." } to plain string declaration, it removes blank lines, it removes seemingly unused versions and libraries, it changes how I arrange my bundles, etc.

Steps to reproduce
Just run interactive mode and see that your file is changed.
The expected interactive file is also created...

@hvisser
Copy link
Contributor

hvisser commented Mar 5, 2024

Yes, currently it will still format the toml file. I think I did this to process unused libraries. The formatting is kind of inherent to the plugin and it would also be applied when adding the updates (basically every time the file is rewritten).

I'll take a look to see if the format pass can be removed when running interactive though. It might need waiting until the plugin has switched to the internal resolver for that. After switching there's no detection of unused dependencies so it's possible that the current behaviour isn't needed anymore.

@hvisser hvisser added this to the 1.0 milestone Oct 18, 2024
@polyoxidonium
Copy link

@hvisser
This is still an issue.
I wanted to use just interactive mode because the original task mess up with my formatting but now I have to revert changes on the toml file.
And btw it does not affect only formatting, but it also removes "unused" dependencies in a false-positive way (boms that are not explicitly referenced) unless the configuration is not adapted.

@hvisser
Copy link
Contributor

hvisser commented Jan 14, 2025

I'm aware, that's why this issue is still open. What I said in #146 (comment) still holds; the next version (1.0) will switch over to the new resolver, which will also fix "disappearing" dependencies that you are experiencing. The new resolver is behind a flag currently, see the release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants