Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wmissing-field-initializers #405

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fix -Wmissing-field-initializers #405

merged 2 commits into from
Apr 9, 2020

Conversation

rojer
Copy link
Contributor

@rojer rojer commented Apr 3, 2020

No description provided.

@geky
Copy link
Member

geky commented Apr 6, 2020

Hi @rojer, thanks for creating a PR. Did this change in v2.2?

I'm happy to bring this in, though the flag should be probably be added to the Makefile to prevent another regression. It looks like it was omitted because of a compiler bug (7d8f8ce), but it would be interesting to see if the fixed GCC has been adopted in Travis yet.

@rojer
Copy link
Contributor Author

rojer commented Apr 6, 2020

Did this change in v2.2?

yes, i think so

see if the fixed GCC has been adopted in Travis yet.

added a commit that removes the flag, let's see if it passes

@rojer
Copy link
Contributor Author

rojer commented Apr 6, 2020

looks like it's ok

@geky
Copy link
Member

geky commented Apr 9, 2020

Time to merge. Thanks for this!

@geky geky merged commit 4c9146e into littlefs-project:master Apr 9, 2020
fengjixuchui referenced this pull request in fengjixuchui/littlefs Apr 9, 2020
Merge pull request ARMmbed#405 from rojer/mfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants