Merge get/list env command #206
Conversation
shivam-Purohit
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
|
@SarthakJain26 its hard to just add a flag and show the whole details. Like not hard but unnecessary cause it will make the command slower if we query all the fields for list environments also. We should consider adding it to descibe or something. WDYT? |
|
i havent touched other part of the code which can be optimised with this new get environment endpoint, we would do that in some other pr. I will create an issue regarding that. |
|
pkg/cmd/get/environments.go
Outdated
| } | ||
| } | ||
|
|
||
| environmentList, err := environment.ListChaosEnvironments(projectID, credentials) |
There was a problem hiding this comment.
Shouldn't we have a check here to see if environmentID is given or not before sending the query
pkg/cmd/get/get.go
Outdated
| @@ -35,6 +35,9 @@ var GetCmd = &cobra.Command{ | |||
| #get list of Chaos Experiment runs | |||
| litmusctl get chaos-experiment-runs --project-id="" | |||
|
|
|||
| #get list of Chaos Environments | |||
| litmusctl get chaos-experiments --project-id="" | |||
There was a problem hiding this comment.
add example for environment-id also
|
@Nageshbansal does the master branch have updated-dependencies? Not rebasing in case, dont want to add extra commit |
|
Not yet, as Pr#209 is still opened. |
shivam-Purohit
force-pushed
the
get_env_update_to_list
branch
from
a099141
to
25e3fd3
Compare
Signed-off-by: Shivam Purohit <[email protected]>
Signed-off-by: Shivam Purohit <[email protected]>
Signed-off-by: Shivam Purohit <[email protected]>
shivam-Purohit
force-pushed
the
get_env_update_to_list
branch
from
25e3fd3
to
49af013
Compare
Merges both
get chaos-environmentandlist chaos-envrionmentscommands into a single command asget chaos-environments.