fix: added missing environmentID flag #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikaysaxena
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
|
The flag had been implemented earlier here, just the flag parser was missing, I have added that. |
neelanjan00
approved these changes
Feb 14, 2024
|
@kartikaysaxena can you please update the flag to environment-id, since this is the casing that we are following. Also please update the example command in connect/connect.go by adding the environment-id flag. |
Sure will do it. |
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
environmentID-flag
branch
from
9dffc18
to
9bf0d4e
Compare
SarthakJain26
requested changes
Feb 15, 2024
pkg/cmd/connect/connect.go
Outdated
| @@ -25,10 +25,10 @@ var ConnectCmd = &cobra.Command{ | |||
| Short: `Connect resources for LitmusChaos Execution plane. | |||
| Examples: | |||
| #connect a Chaos Infrastructure | |||
| litmusctl connect chaos-infra --name="new-chaos-infra" --non-interactive | |||
| litmusctl connect chaos-infra --name="new-chaos-infra" --non-interactive --environment-id="my-environment-id" | |||
There was a problem hiding this comment.
No need to add incase of interactive mode, user will see a prompt to enter the environment-id incase of interactive mode
Signed-off-by: Kartikay <[email protected]>
…a/litmusctl into environmentID-flag
SarthakJain26
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #197