Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README-fr.md #2272

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Create README-fr.md #2272

merged 2 commits into from
Oct 15, 2020

Conversation

alpha2320
Copy link
Contributor

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@codesniffy codesniffy bot added the size/M label Oct 15, 2020
imrajdas and others added 2 commits October 15, 2020 17:41
* Changing version to 1.9

Signed-off-by: Raj Babu Das <[email protected]>

* Changing version to 1.9 [skip-ci]

Signed-off-by: Raj Babu Das <[email protected]>
Signed-off-by: alpha2320 <[email protected]>
Signed-off-by: alpha2320 <[email protected]>
@alpha2320
Copy link
Contributor Author

@ajeshbaby @prithvi1307 please review and merge!

@prithvi1307 prithvi1307 requested a review from ajeshbaby October 15, 2020 12:39
@ajeshbaby ajeshbaby requested a review from imrajdas October 15, 2020 13:10
Copy link
Contributor

@ajeshbaby ajeshbaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alpha2320
Copy link
Contributor Author

@ajeshbaby @prithvi1307 how can i redeem my hacktoberfest swag?

@ajeshbaby ajeshbaby added Hacktoberfest hacktoberfest-accepted Accepted for HacktoberFest labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants