Add pod annotations support #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add podAnnotations value to add podannotations on each components - Add customPodAnnotation value to add podannotations on all components - bumped version 3.11.1 and regenerated docs Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
imrajdas,
ispeakc0de,
Jasstkn,
Jonsy13 and
Saranya-jena
as code owners
|
@Jasstkn @ispeakc0de @imrajdas Tagging you for review / merge of the PR. |
Signed-off-by: Calvin Audier <[email protected]>
|
I can switch to "with" instead of "if" in the deployment if needed. |
Signed-off-by: Calvinaud <[email protected]>
Signed-off-by: Calvin Audier <[email protected]>
|
Hi @Calvinaud We just did the 3.13.x release due to that, your PR got some conflicts. Can you please update your PR. We will take this PR before next release so that it come as part of 3.14.x. |
|
Hello, @Jonsy13, Updated the PR to chart |
Jonsy13
approved these changes
Nov 29, 2024
SarthakJain26
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
This PR is inspired by #274 but which is inactive for quite a long time. If needed, I can close this PR in favor of the old one if it become active again.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]