Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post upgrade hook fix #347

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Conversation

nighthawq7
Copy link
Contributor

What this PR does / why we need it:

It allows users of this helm chart to opt-out for the post upgrade hook.

Which issue this PR fixes

  • fixes 341

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Ulf Karlsson added 2 commits October 30, 2023 15:24
Signed-off-by: Ulf Karlsson <[email protected]>
Signed-off-by: Ulf Karlsson <[email protected]>
Signed-off-by: Ulf Karlsson <[email protected]>
Signed-off-by: Ulf Karlsson <[email protected]>
@nighthawq7 nighthawq7 force-pushed the post-upgrade-hook-fix branch from e402446 to b48198b Compare October 30, 2023 14:25
Copy link
Member

@Jasstkn Jasstkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM. 🚀

@Jasstkn
Copy link
Member

Jasstkn commented Nov 1, 2023

@imrajdas @ispeakc0de hey folks. Can I ask you to take a look?

@Jasstkn
Copy link
Member

Jasstkn commented Nov 3, 2023

@imrajdas @ispeakc0de hey folks. Can I ask you to take a look?

ping

@nighthawq7
Copy link
Contributor Author

Not sure where to ask, but I see that the chart version is of 3.0.1 on master, but that version have not been released.
When/What triggers a release of the charts?

@Jasstkn
Copy link
Member

Jasstkn commented Nov 4, 2023

Not sure where to ask, but I see that the chart version is of 3.0.1 on master, but that version have not been released. When/What triggers a release of the charts?

thanks for the report. fixed: https://github.com/litmuschaos/litmus-helm/releases/tag/litmus-3.0.1

charts/litmus/values.yaml Outdated Show resolved Hide resolved
@nighthawq7 nighthawq7 requested a review from gdsoumya November 6, 2023 10:15
@nighthawq7
Copy link
Contributor Author

nighthawq7 commented Nov 7, 2023

@Jasstkn @imrajdas @ispeakc0de
I'm fairly new to contributing to an open source project. What is the normal lead time to get a pull request through?
To me it seems like a very slow pace at the moment (this simple pull request have activity from 1/3 maintainers) and that will get potential consumer to hesitate to use the tool.

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdsoumya
Copy link
Member

gdsoumya commented Nov 7, 2023

@nighthawq7 Thanks for the contribution!

@gdsoumya gdsoumya merged commit dba4a40 into litmuschaos:master Nov 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants