-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post upgrade hook fix #347
Conversation
Signed-off-by: Ulf Karlsson <[email protected]> Signed-off-by: Ulf Karlsson <[email protected]>
Signed-off-by: Ulf Karlsson <[email protected]> Signed-off-by: Ulf Karlsson <[email protected]>
e402446
to
b48198b
Compare
Signed-off-by: Ulf Karlsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! LGTM. 🚀
@imrajdas @ispeakc0de hey folks. Can I ask you to take a look? |
ping |
Not sure where to ask, but I see that the chart version is of 3.0.1 on master, but that version have not been released. |
thanks for the report. fixed: https://github.com/litmuschaos/litmus-helm/releases/tag/litmus-3.0.1 |
Signed-off-by: Ulf Karlsson <[email protected]>
…helm into post-upgrade-hook-fix
Signed-off-by: Ulf Karlsson <[email protected]>
@Jasstkn @imrajdas @ispeakc0de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nighthawq7 Thanks for the contribution! |
What this PR does / why we need it:
It allows users of this helm chart to opt-out for the post upgrade hook.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]