Add labels in openshift route resource #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add common and custom labels to the route resource - Upgrade chart version to 2.15.12 - Regenerate doc with helm-docs Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
imrajdas,
ispeakc0de and
Jasstkn
as code owners
Signed-off-by: Calvinaud <[email protected]>
gdsoumya
requested changes
Oct 11, 2023
Co-authored-by: gdsoumya <[email protected]> Signed-off-by: Calvinaud <[email protected]>
Jasstkn
approved these changes
Oct 11, 2023
Jasstkn
reviewed
Oct 11, 2023
| @@ -325,6 +325,7 @@ openshift: | |||
| route: | |||
| enabled: false | |||
| name: litmus-portal | |||
| customLabels: {} | |||
There was a problem hiding this comment.
I prefer additionalLabels more but if others are fine, then i doesn't matter much. approving for now.
There was a problem hiding this comment.
In the values.yaml all others resource are using customLabels (https://github.com/litmuschaos/litmus-helm/blob/master/charts/litmus/values.yaml#L10) that why I used the same name.
gdsoumya
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]