Respect service type and make clusterIP default

[Jasstkn]

Signed-off-by: Jasstkn [email protected]

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes Litmus does not honor service.type field when ingress is enabled #256

Special notes for your reviewer:

see also PR with documentation update: litmuschaos/litmus-docs#199

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[dchourasia]

@Jasstkn thanks a lot for a quick turn around, really appreciate it!
Can you please make the same change for backend server service (server-svc.yaml) as well, this will enable us to create/execute litmus workflows using server APIs directly (without going to UI)

Ingress.yaml already has a rule for backend server service as well.

[Jasstkn]

@Jasstkn thanks a lot for a quick turn around, really appreciate it! Can you please make the same change for backend server service (server-svc.yaml) as well, this will enable us to create/execute litmus workflows using server APIs directly (without going to UI)

Ingress.yaml already has a rule for backend server service as well.

I'll take a look into that too, thanks

[Jasstkn]

/run-e2e-all
Test Status: The e2e test has been started please wait for the results ...

---

Experiment	Result	Runtime

---

Test Failed: Some tests are failed please check
Run ID: 2783379804

[Jasstkn]

@imrajdas hi. could you take a look into this PR please?

[dchourasia]

@Jasstkn thank you for these changes, but I see some breaking changes in server-svc.yaml (this file belongs to backend server service and not graphql (mongo) service:

Can you please check following list:

1. line # 14
   Expected: type: {{ .Values.portal.server.service.type }}
   Actual : type: {{ .Values.portal.server.graphqlServer.service.type }}

2. line # 9
   Expected: {{- with .Values.portal.server.service.annotations }}
   Actual : {{- with .Values.portal.server.graphqlServer.service.annotations }}

Appreciate the efforts!

[Jasstkn]

@Jasstkn thank you for these changes, but I see some breaking changes in server-svc.yaml (this file belongs to backend server service and not graphql (mongo) service:

Can you please check following list:

1. line # 14
   Expected: type: {{ .Values.portal.server.service.type }}
   Actual : type: {{ .Values.portal.server.graphqlServer.service.type }}
2. line # 9
   Expected: {{- with .Values.portal.server.service.annotations }}
   Actual : {{- with .Values.portal.server.graphqlServer.service.annotations }}

Appreciate the efforts!

it's not really a breaking-breaking change but it makes sense to manage service type per actual service. This change updates the general logic. You can see graphql's ports in the service template as well.
Could you elaborate a bit what do you mean?

[dchourasia]

@Jasstkn I see, yes this perfectly makes sense to have use separate fields for each service type. I was confused if there is any use of portal.server.service.type anymore.

So yes, not a breaking change, we will update our values.yaml accordingly.
thank you!

[Jasstkn]

FYI: I'll write additional documentation about upgrade process to the README later today.

[Jasstkn]

@imrajdas @ispeakc0de hi folks. Could you review this MR? I added upgrade notes as it's good practice to have some docs for users so they know how to upgrade their chart.

[Jasstkn]

@Jonsy13 hey! thanks for approving it. could you help me with merging this PR and update for docs: litmuschaos/litmus-docs#199?

[Jonsy13]

Hi @Jasstkn , Changes looks good to me. Gave a comment on docs PR.
Adding @imrajdas for review as well.

[imrajdas]

@Jasstkn - Circleci checks are pending. Can you update this PR?

[Jonsy13]

Hi @Jasstkn Should i merge this PR?

[Jasstkn]

Hi @Jasstkn Should i merge this PR?

merging this one. thanks!

fyi: docs PR is also updated.