Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBI migration of Images - go-runner #707

Merged
merged 22 commits into from
Aug 23, 2024

Conversation

dusdjhyeon
Copy link
Contributor

What this PR does / why we need it:
Migrate the base images of the g-runner container images of LitmusChaos from experiment-alpine to ubi minimal.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4634 (litmuschaos/litmus#4634)

Reference: https://github.com/litmuschaos/litmus/wiki/Chaos-Experiments-Go%E2%80%90Runner-Base-Image-Migration-to-RedHat-UBI-Image

Special notes for your reviewer:

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
@Jonsy13
Copy link
Contributor

Jonsy13 commented Aug 21, 2024

One more change, we will have to do is to update in all github action workflows -

        with:
          go-version: 1.18

to

        with:
          go-version: 1.20

to complete our 1.20 migration.

@Jonsy13
Copy link
Contributor

Jonsy13 commented Aug 21, 2024

One change missing from https://github.com/litmuschaos/litmus/wiki/Chaos-Experiments-Go%E2%80%90Runner-Base-Image-Migration-to-RedHat-UBI-Image

Experiment Code using ps will have to be changed as ps aux works a little different in case of UBI -
sudo kill -9 $(ps aux | grep [t]oxiproxy | awk 'FNR==1{print $1}') has to be changed to sudo kill -9 $(ps aux | grep [t]oxiproxy | awk 'FNR==2{print $2}')

You can try searching for ps aux & update those instances.

build/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
@Jonsy13 Jonsy13 merged commit fc646d6 into litmuschaos:master Aug 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants