Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Add configurable master pod timeout to Kubernetes backend #1390

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

bystepii
Copy link
Contributor

@bystepii bystepii commented Jul 31, 2024

This pull request introduces a new configurable parameter, master_timeout, to the Kubernetes backend.

Motivation

There may be jobs that last more than 10 minutes, which is the default master pod duration. Although the master pod is expected to restart automatically, there are cases where it does not restart or after restarting some jobs are lost, resulting in jobs shown in Lithops logs as Pending.

The new master_timeout parameter mitigates these issues by allowing to configure a suitable timeout based on the job requirements.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@JosepSampe
Copy link
Member

Looks good, thanks @bystepii!

@JosepSampe JosepSampe merged commit c690601 into lithops-cloud:master Jul 31, 2024
7 checks passed
@kikemolina3
Copy link
Contributor

Great contribution! Thank you @bystepii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants