feat(api): updates (#215)

lithic-com · May 1, 2024 · 0548781 · 0548781
1 parent 961f319
commit 0548781
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 16 deletions.
diff --git a/lithic-java-core/src/main/kotlin/com/lithic/api/models/KycExempt.kt b/lithic-java-core/src/main/kotlin/com/lithic/api/models/KycExempt.kt
@@ -42,7 +42,7 @@ private constructor(
      * KYC Exempt user's current address - PO boxes, UPS drops, and FedEx drops are not acceptable;
      * APO/FPO are acceptable. Only USA addresses are currently supported.
      */
-    fun address(): Optional<Address> = Optional.ofNullable(address.getNullable("address"))
+    fun address(): Address = address.getRequired("address")
 
     /**
      * Only applicable for customers using the KYC-Exempt workflow to enroll authorized users of
@@ -115,7 +115,7 @@ private constructor(
 
     fun validate(): KycExempt = apply {
         if (!validated) {
-            address().map { it.validate() }
+            address().validate()
             businessAccountToken()
             email()
             externalId()

diff --git a/lithic-java-core/src/main/kotlin/com/lithic/api/models/Transaction.kt b/lithic-java-core/src/main/kotlin/com/lithic/api/models/Transaction.kt
@@ -1375,6 +1375,10 @@ private constructor(
                 @JvmField
                 val INSUFFICIENT_FUNDS = DetailedResult(JsonField.of("INSUFFICIENT_FUNDS"))
 
+                @JvmField val INVALID_DRIVER = DetailedResult(JsonField.of("INVALID_DRIVER"))
+
+                @JvmField val INVALID_VEHICLE = DetailedResult(JsonField.of("INVALID_VEHICLE"))
+
                 @JvmField
                 val LITHIC_SYSTEM_ERROR = DetailedResult(JsonField.of("LITHIC_SYSTEM_ERROR"))
 
@@ -1474,6 +1478,8 @@ private constructor(
                 FORMAT_ERROR,
                 INSUFFICIENT_FUNDING_SOURCE_BALANCE,
                 INSUFFICIENT_FUNDS,
+                INVALID_DRIVER,
+                INVALID_VEHICLE,
                 LITHIC_SYSTEM_ERROR,
                 LITHIC_SYSTEM_RATE_LIMIT,
                 MALFORMED_ASA_RESPONSE,
@@ -1525,6 +1531,8 @@ private constructor(
                 FORMAT_ERROR,
                 INSUFFICIENT_FUNDING_SOURCE_BALANCE,
                 INSUFFICIENT_FUNDS,
+                INVALID_DRIVER,
+                INVALID_VEHICLE,
                 LITHIC_SYSTEM_ERROR,
                 LITHIC_SYSTEM_RATE_LIMIT,
                 MALFORMED_ASA_RESPONSE,
@@ -1580,6 +1588,8 @@ private constructor(
                     FORMAT_ERROR -> Value.FORMAT_ERROR
                     INSUFFICIENT_FUNDING_SOURCE_BALANCE -> Value.INSUFFICIENT_FUNDING_SOURCE_BALANCE
                     INSUFFICIENT_FUNDS -> Value.INSUFFICIENT_FUNDS
+                    INVALID_DRIVER -> Value.INVALID_DRIVER
+                    INVALID_VEHICLE -> Value.INVALID_VEHICLE
                     LITHIC_SYSTEM_ERROR -> Value.LITHIC_SYSTEM_ERROR
                     LITHIC_SYSTEM_RATE_LIMIT -> Value.LITHIC_SYSTEM_RATE_LIMIT
                     MALFORMED_ASA_RESPONSE -> Value.MALFORMED_ASA_RESPONSE
@@ -1638,6 +1648,8 @@ private constructor(
                     FORMAT_ERROR -> Known.FORMAT_ERROR
                     INSUFFICIENT_FUNDING_SOURCE_BALANCE -> Known.INSUFFICIENT_FUNDING_SOURCE_BALANCE
                     INSUFFICIENT_FUNDS -> Known.INSUFFICIENT_FUNDS
+                    INVALID_DRIVER -> Known.INVALID_DRIVER
+                    INVALID_VEHICLE -> Known.INVALID_VEHICLE
                     LITHIC_SYSTEM_ERROR -> Known.LITHIC_SYSTEM_ERROR
                     LITHIC_SYSTEM_RATE_LIMIT -> Known.LITHIC_SYSTEM_RATE_LIMIT
                     MALFORMED_ASA_RESPONSE -> Known.MALFORMED_ASA_RESPONSE

diff --git a/lithic-java-core/src/test/kotlin/com/lithic/api/models/KycExemptTest.kt b/lithic-java-core/src/test/kotlin/com/lithic/api/models/KycExemptTest.kt
@@ -11,12 +11,6 @@ class KycExemptTest {
     fun createKycExempt() {
         val kycExempt =
             KycExempt.builder()
-                .email("string")
-                .firstName("string")
-                .kycExemptionType(KycExempt.KycExemptionType.AUTHORIZED_USER)
-                .lastName("string")
-                .phoneNumber("string")
-                .workflow(KycExempt.Workflow.KYC_EXEMPT)
                 .address(
                     Address.builder()
                         .address1("123 Old Forest Way")
@@ -27,19 +21,18 @@ class KycExemptTest {
                         .address2("string")
                         .build()
                 )
+                .email("string")
+                .firstName("string")
+                .kycExemptionType(KycExempt.KycExemptionType.AUTHORIZED_USER)
+                .lastName("string")
+                .phoneNumber("string")
+                .workflow(KycExempt.Workflow.KYC_EXEMPT)
                 .businessAccountToken("string")
                 .externalId("string")
                 .build()
         assertThat(kycExempt).isNotNull
-        assertThat(kycExempt.email()).isEqualTo("string")
-        assertThat(kycExempt.firstName()).isEqualTo("string")
-        assertThat(kycExempt.kycExemptionType())
-            .isEqualTo(KycExempt.KycExemptionType.AUTHORIZED_USER)
-        assertThat(kycExempt.lastName()).isEqualTo("string")
-        assertThat(kycExempt.phoneNumber()).isEqualTo("string")
-        assertThat(kycExempt.workflow()).isEqualTo(KycExempt.Workflow.KYC_EXEMPT)
         assertThat(kycExempt.address())
-            .contains(
+            .isEqualTo(
                 Address.builder()
                     .address1("123 Old Forest Way")
                     .city("Omaha")
@@ -49,6 +42,13 @@ class KycExemptTest {
                     .address2("string")
                     .build()
             )
+        assertThat(kycExempt.email()).isEqualTo("string")
+        assertThat(kycExempt.firstName()).isEqualTo("string")
+        assertThat(kycExempt.kycExemptionType())
+            .isEqualTo(KycExempt.KycExemptionType.AUTHORIZED_USER)
+        assertThat(kycExempt.lastName()).isEqualTo("string")
+        assertThat(kycExempt.phoneNumber()).isEqualTo("string")
+        assertThat(kycExempt.workflow()).isEqualTo(KycExempt.Workflow.KYC_EXEMPT)
         assertThat(kycExempt.businessAccountToken()).contains("string")
         assertThat(kycExempt.externalId()).contains("string")
     }