Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes annotation of **kwargs across the library #439

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fixes annotation of **kwargs across the library #439

merged 2 commits into from
Aug 31, 2022

Conversation

peterschutt
Copy link
Contributor

@peterschutt peterschutt commented Aug 31, 2022 •
edited
Loading

Changes **kwargs: Dict[str, Any] to **kwargs: Any in MiddlewareProtocol.__init__() signature.

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@peterschutt peterschutt force-pushed the middleware-proto-typing branch from 4ddb729 to b5a1a0f Compare August 31, 2022 11:03
@peterschutt peterschutt requested a review from Goldziher August 31, 2022 11:04
@peterschutt
Fixes annotation of **kwargs across the library.
5dd3d04 
Replaces instances of `**kwargs: Dict[str, Any]` with `**kwargs: Any`.
@peterschutt peterschutt force-pushed the middleware-proto-typing branch from b5a1a0f to 5dd3d04 Compare August 31, 2022 12:27
@peterschutt peterschutt changed the title Fixes annotation of **kwargs in MiddlewareProtocol.__init__(). Fixes annotation of **kwargs across the library Aug 31, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@peterschutt peterschutt merged commit a5c9051 into main Aug 31, 2022
@peterschutt peterschutt deleted the middleware-proto-typing branch August 31, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterschutt @Goldziher