Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and update Cargo.toml #15

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix build and update Cargo.toml #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fcaa30
Remove unneeded deps.
Dec 24, 2024
49262a9
Fix build.
Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ target = "valida-unknown-baremetal-gnu"
linker = "/valida-toolchain/bin/ld.lld"
rustflags = [
"-C", "link-arg=/valida-toolchain/ValidaEntryPoint.o",
"-C", "link-arg=/valida-toolchain/io.o",
"-C", "link-arg=--script=/valida-toolchain/valida.ld",
"-C", "link-arg=/valida-toolchain/lib/valida-unknown-baremetal-gnu/libc.a",
"-C", "link-arg=/valida-toolchain/lib/valida-unknown-baremetal-gnu/libm.a",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does getting rid of this line do, and why is this change correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as per https://github.com/lita-xyz/valida-toolchain/pull/709. Marcin removed the need for this there.

"-C", "link-arg=--noinhibit-exec",
]

[env]
Expand Down
5 changes: 1 addition & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
[package]
name = "fibonacci"
version = "0.1.0"
edition = "2021"

[dependencies]
valida-rs = { git = "https://github.com/lita-xyz/valida-rs.git", branch = "no-deps" }
edition = "2021"