Carlo/8 bits #10
Open
Carlo/8 bits #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CarloModicaPortfolio
commented
Jan 7, 2025
CarloModicaPortfolio
commented
- 8 bits libs
- refactor to PrimeField32
- added extraction for multiset chek
morganthomas
requested changes
Jan 7, 2025
| @@ -14,7 +16,7 @@ use crate::{NUM_ROUNDS, RATE_LIMBS, U64_LIMBS}; | |||
| /// convention of `x, y, z` order, but it has the benefit that input lists map to AIR columns in a | |||
| /// nicer way. | |||
| #[repr(C)] | |||
| pub(crate) struct KeccakCols<T> { | |||
| pub struct KeccakCols<T> { | |||
| /// The `i`th value is set to 1 if we are in the `i`th round, otherwise 0. | |||
| pub step_flags: [T; NUM_ROUNDS], | |||
|
|
|||
There was a problem hiding this comment.
We could unify the postimage columns with the a_prime_prime columns, since these are never both used in the same row. They effectively serve the same purpose, and by unifying these, we can get rid of the .when(not_final_row) conditions. Doing the latter may reduce the degree of the STARK from 4 to 3.
There was a problem hiding this comment.
Similarly, @CarloModicaPortfolio says we can unify step_flags[NUM_ROUNDS-1] with export.
| @@ -168,5 +179,78 @@ impl<AB: AirBuilder> Air<AB> for KeccakAir { | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
All of the below can go away when we unify the columns as discussed elsewhere in this review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.