Ensure update/render can be triggered by rendering #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #549. Changes `UpdatingElement` such that updates can occur after calling `super.update()`. Changes `LitElement` such that update/render can occur as a result of rendering, for example if an event listener is triggered that sets a property.
Update should be marked ready for additional/new updates when: 1. After the `update` method is called (e.g. after super.update(...)) 2. If `shouldUpdate` return false. Returning false indicates that this update turn should be ignored but future updates should be processed. 3. If there is an exception during `update`.
justinfagnani
approved these changes
Jan 17, 2020
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549. Changes
UpdatingElementsuch that updates can occur after callingsuper.update(). ChangesLitElementsuch that update/render can occur as a result of rendering, for example if an event listener is triggered that sets a property.