Fixes queryAssignedNodes when querying for nodes on browsers that do … #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have Element.matches Fixes #1088.
justinfagnani
approved these changes
Oct 17, 2020
src/lib/decorators.ts
Outdated
| @@ -465,9 +465,10 @@ export function queryAssignedNodes( | |||
| if (nodes && selector) { | |||
| nodes = nodes.filter( | |||
| (node) => node.nodeType === Node.ELEMENT_NODE && | |||
| (node as Element).matches ? | |||
| // tslint:disable-next-line:no-any testing existence on older browsers | |||
| ((node as any).matches ? | |||
There was a problem hiding this comment.
Since the DOM types include .matches you shouldn't need the as any cast. Did the old code not type-check?
kevinpschaaf
approved these changes
Oct 19, 2020
| (node as Element).matches(selector) : | ||
| legacyMatches.call(node as Element, selector)); | ||
| // tslint:disable-next-line:no-any testing existence on older browsers | ||
| ((node as any).matches ? |
There was a problem hiding this comment.
Still curious about this cast here. Why is it necessary?
There was a problem hiding this comment.
TypeScript complains that the check is unnecessary becausematches always exists. The previous code probably didn't analyze path.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…have Element.matches
Fixes #1088.