Remove logging module configuration from the library code #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 87.85% 87.73% -0.13%
==========================================
Files 33 33
Lines 2050 2046 -4
Branches 305 305
==========================================
- Hits 1801 1795 -6
- Misses 185 186 +1
- Partials 64 65 +1
☔ View full report in Codecov by Sentry. |
atugushev
reviewed
Aug 7, 2023
| logger = logging.getLogger(f"ansq {unique_name}" if unique_name else "ansq") | ||
| log_format = "%(asctime)s - %(levelname)s - %(name)s: %(message)s" | ||
| logging.basicConfig(format=log_format) | ||
| logger.setLevel(logging.DEBUG if debug else logging.INFO) |
There was a problem hiding this comment.
then we don't need the debug param at all?
atugushev
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.