-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 and add Python 3.12 support #1593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request updates the Python version used in GitHub Actions workflows and refactors type hinting syntax in the codebase. It aims to drop support for Python 3.8 and introduce support for Python 3.12, aligning with the latest Python releases.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that all dependencies are fully compatible with Python 3.12 before merging this pull request.
- Consider the impact on users who may still be using Python 3.8 and whether maintaining support for this version is necessary.
- Verify that the deployment environment and all necessary dependencies are available and stable for Python 3.12.
- Review the broader impact of these changes on the codebase, including any potential issues that may arise from dropping Python 3.8 support.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
…l', autots/models/sklearn.py", line 3495)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
+ Coverage 91.71% 91.73% +0.02%
==========================================
Files 43 43
Lines 2800 2807 +7
Branches 349 299 -50
==========================================
+ Hits 2568 2575 +7
Misses 213 213
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Related issues
Drop Python 3.8 and add Python 3.12 support.
Tests with pip installation will be done with 3.9, 3.10, 3.11, 3.12 version.
Because pyproject-flake8 does not support Python 3.12, Python 3.11 will be used for quality check and Poetry test.
Fix related warnings and errors.
What was changed