Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 and add Python 3.12 support #1593

Merged
merged 36 commits into from
Feb 4, 2024
Merged

Drop Python 3.8 and add Python 3.12 support #1593

merged 36 commits into from
Feb 4, 2024

Conversation

@lisphilar lisphilar added enhancement New feature or request dependencies Pull requests that update a dependency file development Add tests or refactoring labels Feb 3, 2024
@lisphilar lisphilar added this to the Release 3.1.0 milestone Feb 3, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request updates the Python version used in GitHub Actions workflows and refactors type hinting syntax in the codebase. It aims to drop support for Python 3.8 and introduce support for Python 3.12, aligning with the latest Python releases.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all dependencies are fully compatible with Python 3.12 before merging this pull request.
  • Consider the impact on users who may still be using Python 3.8 and whether maintaining support for this version is necessary.
  • Verify that the deployment environment and all necessary dependencies are available and stable for Python 3.12.
  • Review the broader impact of these changes on the codebase, including any potential issues that may arise from dropping Python 3.8 support.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4adc60) 91.71% compared to head (4b48a12) 91.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.02%     
==========================================
  Files          43       43              
  Lines        2800     2807       +7     
  Branches      349      299      -50     
==========================================
+ Hits         2568     2575       +7     
  Misses        213      213              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lisphilar lisphilar merged commit a6d6a9a into main Feb 4, 2024
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue1592 branch February 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment