fix: Respect custom repositories when checking transitive deps #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were hardcoding the standard maven repositories when checking for outdated transitive dependencies, which means that it didn't work in projects that use custom maven repositories. This change preserves the original repositories from the project when checking for transitive dependencies. We fallback to standard repositories (Maven Central and Clojars) if the project doesn't specify any repositories. Fixes liquidz#230.
liquidz
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
@marcobiscaro2112 Thank you for your contribution!
Great work. This PR looks good to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were hardcoding the standard maven repositories when checking for outdated transitive dependencies, which means that it didn't work in projects that use custom maven repositories.
This change preserves the original repositories from the project when checking for transitive dependencies. We fallback to standard repositories (Maven Central and Clojars) if the project doesn't specify any repositories.
Fixes #230.