Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cheshire with clojure.data.json #102

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Replace cheshire with clojure.data.json #102

merged 1 commit into from
Aug 6, 2021

Conversation

dpassen
Copy link
Contributor

@dpassen dpassen commented Aug 5, 2021

  • Keep Jackson conflicts far away

Addresses #101

- Keep Jackson conflicts far away
@vemv
Copy link
Contributor

vemv commented Aug 5, 2021

You were quicker than me :) LGTM

@@ -5,7 +5,7 @@
org.clojure/data.zip {:mvn/version "1.0.0"}
org.clojure/tools.cli {:mvn/version "1.0.206"}
org.clojure/tools.deps.alpha {:mvn/version "0.12.1003"}
cheshire/cheshire {:mvn/version "5.10.1"}
org.clojure/data.json {:mvn/version "2.4.0"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is meant to be kept alphabetized (within org.clojure), easy change

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :)

Copy link
Owner

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpassen Sorry for late reaction.
LGTM. Thanks!

@liquidz liquidz merged commit 5aaa62d into liquidz:main Aug 6, 2021
@dpassen
Copy link
Contributor Author

dpassen commented Aug 6, 2021

@liquidz Thank you. Hope the second vaccine didn't hit you too hard :-)

@dpassen dpassen deleted the remove-cheshire branch August 6, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants