Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not detect outdated version of clj-kondo with DeLaGuardo/setup-clojure GitHub Action #248

Closed
devurandom opened this issue Feb 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@devurandom
Copy link

Given the following .github/workflows/lint.yml file:

name: Lint

on:
  pull_request

jobs:
  lint:
    runs-on: ubuntu-22.04
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Prepare Java
        uses: actions/setup-java@v4
        with:
          distribution: 'temurin'
          java-version: '11'
      - name: Install Clojure tools
        uses: DeLaGuardo/[email protected]
        with:
          cli: 1.11.1.1435
          clj-kondo: 2023.07.13

I see:

❯ clj -Tantq outdated :upgrade true
[##################################################] 4/4
All dependencies are up-to-date.

The current version of clj-kondo as of this report is 2023.12.15.

This is using:

❯ clj -Ttools list
TOOL      LIB                                 TYPE  VERSION
antq      com.github.liquidz/antq             :git  2.8.1173
...
@liquidz
Copy link
Owner

liquidz commented Feb 10, 2024

@devurandom Thank you for your reporting!
I could reproduce the problem. I'll fix it :)

liquidz added a commit that referenced this issue Feb 10, 2024
liquidz added a commit that referenced this issue Feb 10, 2024
@liquidz
Copy link
Owner

liquidz commented Feb 10, 2024

@devurandom I've fixed dependencies detector and upgrader in dev branch to support :bb, :clj-kondo, :cljfmt, :cljstyle, and :zprint parameters on setup-clojure action.
Could you try dev branch?

@liquidz liquidz added the bug Something isn't working label Feb 10, 2024
@devurandom
Copy link
Author

I just tested badf6c9 and it suggests to update clj-kondo in GHA in addition to deps.edn:

| :file                                    | :name                                     | :current                                 | :latest                                  |
|------------------------------------------+-------------------------------------------+------------------------------------------+------------------------------------------|
| .github/workflows/lint.yml               | DeLaGuardo/setup-clojure                  | 12.3                                     | 12.5                                     |
|                                          | DeLaGuardo/setup-clojure                  | 12.3                                     | 12.5                                     |
|                                          | clj-kondo/clj-kondo                       | 2023.12.15                               | 2024.02.12                               |
| deps.edn                                 | clj-kondo/clj-kondo                       | 2023.12.15                               | 2024.02.12                               |

Thanks!

@liquidz
Copy link
Owner

liquidz commented Feb 23, 2024

@devurandom Thank you for your confirmation!
Just released v2.8.1185 :)

@liquidz liquidz closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants