Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ^:antq/ignore for ignoring package #190

Closed
kimmoahola opened this issue Nov 16, 2022 · 8 comments
Closed

Add support for ^:antq/ignore for ignoring package #190

kimmoahola opened this issue Nov 16, 2022 · 8 comments

Comments

@kimmoahola
Copy link

Add support for ignoring the upgrade of a package directly in the package definition.

I think ^:ignore or ^:antq/ignore would be handy in package definition in deps.edn. I think it's good to mark 'ignore' directly to the package definition because easy to spot there when I have 30 packages in a project.

depot has that kind of meta to ignore stuff: https://github.com/Olical/depot#controlling-which-part-of-the-file-are-checked

Example snip from deps.edn:

hikari-cp/hikari-cp ^:antq/ignore {:mvn/version "2.14.0"} ;; Greater than 2.14.0 does not work with java 8.
@liquidz
Copy link
Owner

liquidz commented Nov 16, 2022

@kimmoahola
We already have --exclude option and deps.edn also have :exclustions key.
So how about :antq/exclude ?

liquidz added a commit that referenced this issue Nov 16, 2022
@kimmoahola
Copy link
Author

Yes that would be good for consistency!

@liquidz
Copy link
Owner

liquidz commented Nov 16, 2022

I've added support for :antq/exclude for trial in dev branch.
Could you try? @kimmoahola

@kimmoahola
Copy link
Author

I confirm that it works great. Thank you for quick response!

@liquidz
Copy link
Owner

liquidz commented Nov 16, 2022

Thanks for your confirmation!
I'll add same support for leiningen, shadow-cljs, etc.

liquidz added a commit that referenced this issue Nov 17, 2022
liquidz added a commit that referenced this issue Nov 17, 2022
liquidz added a commit that referenced this issue Nov 17, 2022
liquidz added a commit that referenced this issue Nov 19, 2022
@liquidz
Copy link
Owner

liquidz commented Nov 19, 2022

@kimmoahola Just released v2.2.962 #191

@liquidz liquidz closed this as completed Nov 19, 2022
@liquidz
Copy link
Owner

liquidz commented Nov 19, 2022

@kimmoahola
Copy link
Author

Thank you! Tested it and it seems 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants