Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding provider to convert #806

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

steve-fraser
Copy link
Contributor

@steve-fraser steve-fraser commented Jan 8, 2024

What this PR does / why we need it:

Added missing provider to convert method

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Callisto13 Callisto13 added the kind/bug Something isn't working label Jan 8, 2024
@Callisto13
Copy link
Member

Thanks @steve-fraser could you fix the tests and push again?

@steve-fraser
Copy link
Contributor Author

@Callisto13 do you need to approve it to run the test?

@Callisto13
Copy link
Member

@steve-fraser are you running the build or tests locally before you push?

@steve-fraser
Copy link
Contributor Author

@Callisto13 I wasn't before, but I did now and everything seems to be passing after a few commits :)

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c467027) 58.18% compared to head (8007c58) 58.21%.

❗ Current head 8007c58 differs from pull request most recent head 03d3230. Consider uploading reports for the commit 03d3230 to get more accurate results

Files Patch % Lines
infrastructure/grpc/convert.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   58.18%   58.21%   +0.03%     
==========================================
  Files          56       56              
  Lines        2705     2707       +2     
==========================================
+ Hits         1574     1576       +2     
  Misses        985      985              
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2024
@richardcase richardcase added this to the v0.7.0 milestone Jul 8, 2024
@richardcase richardcase enabled auto-merge (squash) July 8, 2024 10:19
@richardcase richardcase disabled auto-merge July 10, 2024 07:58
@richardcase richardcase merged commit 15c53d7 into liquidmetal-dev:main Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants