-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding provider to convert #806
Conversation
Thanks @steve-fraser could you fix the tests and push again? |
@Callisto13 do you need to approve it to run the test? |
@steve-fraser are you running the build or tests locally before you push? |
@Callisto13 I wasn't before, but I did now and everything seems to be passing after a few commits :) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 58.18% 58.21% +0.03%
==========================================
Files 56 56
Lines 2705 2707 +2
==========================================
+ Hits 1574 1576 +2
Misses 985 985
Partials 146 146 ☔ View full report in Codecov by Sentry. |
This PR is stale because it has been open 30 days with no activity. |
What this PR does / why we need it:
Added missing provider to convert method
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: