Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added test coverage and upload codecov #79

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Sep 8, 2021

What this PR does / why we need it:

Track the code coverage over time. This change adds a unit-test with coverage makefile target and updates the test GHA workflow to upload the results to codecov

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #80

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Test coverage tracking with codecov integration

@richardcase richardcase added the kind/feature New feature or request label Sep 8, 2021
@richardcase richardcase force-pushed the coverage branch 12 times, most recently from 25bd5bf to 6ab6b0a Compare September 8, 2021 16:58
@github-actions github-actions bot added size/s and removed size/xs labels Sep 8, 2021
@richardcase richardcase force-pushed the coverage branch 5 times, most recently from 531f08a to 66bda6d Compare September 8, 2021 17:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a1aff98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage        ?   67.41%           
=======================================
  Files           ?       23           
  Lines           ?      758           
  Branches        ?        0           
=======================================
  Hits            ?      511           
  Misses          ?      184           
  Partials        ?       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aff98...38e9c36. Read the comment docs.

@richardcase richardcase changed the title chore: added test coverage and upload coveralls chore: added test coverage and upload codecov Sep 9, 2021
Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@richardcase richardcase merged commit e14f99a into main Sep 9, 2021
@richardcase richardcase deleted the coverage branch September 9, 2021 15:35
@richardcase
Copy link
Member Author

Thanks @bigkevmcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage Tracking
3 participants