Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): this release adds go mod tidy after the updates #716

Merged
merged 1 commit into from
May 25, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented May 25, 2023

kind/feature

What this PR does / why we need it:

The dependabot bundler was missing a go mod tidy after performing go get which could end up leaving the mod files dirty.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Skarlso Skarlso added the kind/feature New feature or request label May 25, 2023
@Skarlso Skarlso requested review from yitsushi and Callisto13 May 25, 2023 05:08
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eb239ae) 58.26% compared to head (3a9f088) 58.26%.

❗ Current head 3a9f088 differs from pull request most recent head 833abe3. Consider uploading reports for the commit 833abe3 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files          56       56           
  Lines        2705     2705           
=======================================
  Hits         1576     1576           
  Misses        984      984           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yitsushi yitsushi added kind/chore Neither feature nor bug nor improvement. Busy work and removed kind/feature New feature or request labels May 25, 2023
@yitsushi
Copy link
Contributor

Sorry for the extra failed check. I wanted to update the label to chore but forgot to remove the feature label, so it did not like it has two kind labels.

@Skarlso
Copy link
Contributor Author

Skarlso commented May 25, 2023

No worries. :)

@Skarlso Skarlso merged commit 048c991 into main May 25, 2023
@Skarlso Skarlso deleted the bundler-v0017 branch May 25, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Neither feature nor bug nor improvement. Busy work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants