Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ref): add examples for dependabot bundler #656

Merged
merged 1 commit into from
Mar 5, 2023
Merged

chore(ref): add examples for dependabot bundler #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,21 @@ pull request. This PR is not signed and has the label `user-signing-required`. T
done by a maintainer of the repository. Check out the PR and push an amending commit into
the existing branch. Then, the PR can be merged.

For an example, take a look at this pull request: [Bundle dependabot pull requests](https://github.com/weaveworks-liquidmetal/flintlock/pull/655).

It was created by [this](https://github.com/weaveworks-liquidmetal/flintlock/actions/runs/4335326798) action triggered on the main branch.

Once the pull request was opened, a maintainer created a commit into it by checking out the branch, then running a `git commit --amend`.

```bash
# git pull if not already up-to-date
git checkout -b bundler-1678007734 origin/bundler-1678007734
git commit --amend
git push -f
```

After this, GitHub will start running the PR actions and it can eventually be merged.

# ADRs (Architectural Decision Records)

Any impactful decisions to the architecture, design, development and behaviour
Expand Down