Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back support for mount points #610

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Dec 20, 2022

What this PR does / why we need it:

This change adds back support for mounting volumes. This was initially done to support external kernel modules.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relates #537

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@richardcase richardcase added kind/feature New feature or request area/api Indicates an issue or PR relates to the APIs labels Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 56.53% // Head: 56.29% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (bc0c71d) compared to base (7aa5502).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   56.53%   56.29%   -0.25%     
==========================================
  Files          57       57              
  Lines        2768     2780      +12     
==========================================
  Hits         1565     1565              
- Misses       1061     1071      +10     
- Partials      142      144       +2     
Impacted Files Coverage Δ
core/application/commands.go 64.95% <0.00%> (-1.13%) ⬇️
core/models/volumes.go 0.00% <0.00%> (ø)
core/plans/microvm_create_update.go 50.00% <0.00%> (-1.90%) ⬇️
infrastructure/grpc/convert.go 40.33% <0.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yitsushi yitsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions.

core/steps/cloudinit/disk_mount.go Show resolved Hide resolved
core/steps/cloudinit/disk_mount.go Show resolved Hide resolved
core/steps/cloudinit/disk_mount.go Show resolved Hide resolved
@richardcase richardcase changed the title [WIP] feat: add back support for mount points feat: add back support for mount points Jan 7, 2023
@richardcase richardcase marked this pull request as ready for review January 7, 2023 13:54
This change adds back support for mounting volumes. This was initially
done to support external kernel modules.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase merged commit 97f4f12 into liquidmetal-dev:main Jan 9, 2023
@richardcase richardcase deleted the mount_point branch January 9, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR relates to the APIs kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants