fix: Set address based on interface in provision.sh #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In machines with less simple or "clean" networking, the provision script could discover multiple `default` interfaces and multiple internal ips. This led to a messed up config and obviously flintlockd would not start. This commit changes the script so that if more than one is found, just the first `default` interface is set. The found interface is then used to find a single associated internal address. There are flags to override both these options, which is what most people will be doing, but the default behaviour needs to work too.
richardcase
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In machines with less simple or "clean" networking, the provision script could discover multiple
defaultinterfaces and multiple internal ips. This led to a messed up config and obviously flintlockd would not start.This commit changes the script so that if more than one is found, just the first
defaultinterface is set.The found interface is then used to find a single associated internal address.
There are flags to override both these options, which is what most people will be doing, but the default behaviour needs to work too.